FAQ

[davidalayachew]

I'm not married to the format. The hard work, of finding the discussions and linking them inline, is being done. Just want to make sure that we get SOMETHING out there, so that we can have a definitive place to link new folks to when they have questions, for further reading.

---

Progress

• Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/amber-docs.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/amber-docs.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/amber-docs/pull/27.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back davidalayachew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@davidalayachew This change is no longer ready for integration - check the PR body for details.

[openjdk]

⚠️ @davidalayachew a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 138e8c994a8098f26c5333a90713970d9dc42a3c
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[davidalayachew]

/integrate

[openjdk]

@davidalayachew
Your change (at version d859059) is now ready to be sponsored by a Committer.

[mlbridge]

Webrevs

• 04: Full - Incremental (cfae2ead)
• 03: Full - Incremental (abbc2dde)
• 02: Full - Incremental (aeb42b72)
• 01: Full - Incremental (fff7c75c)
• 00: Full (d8590593)

[davidalayachew]

Turned it back into draft, in anticipation of moving this work to a different branch of amber-docs. This change is getting significant enough that it makes more sense to nerge to a feature branch, then merge into main once we are happy (enough) with the results.