Document quoteOp and quotedOp methods

[mabbay]

Specify the behaviour of quoteOp and quotedOp methods.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer) ⚠️ Review applies to 01cbb329

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/512/head:pull/512
$ git checkout pull/512

Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.org/babylon.git pull/512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 512

View PR using the GUI difftool:
$ git pr show -t 512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/512.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Document quoteOp and quotedOp methods

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the code-reflection branch:

• 4a88aba: Rearrange lowering.
• c3b86bb: Stop intellij red-squiggling lambda parms called value
• 939aeaa: [samples] Apply type conversion for the int-shift function after the new result op has been built
• ... and 13 more: https://git.openjdk.org/babylon/compare/326717927244f691793cb11ffb2027c0175910a0...code-reflection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 08: Full - Incremental (a8653ae4)
• 07: Full - Incremental (01cbb329)
• 06: Full - Incremental (34cc6a8f)
• 05: Full - Incremental (1fcefbcf)
• 04: Full - Incremental (1781cdb0)
• 03: Full - Incremental (e75f36f9)
• 02: Full - Incremental (659f018f)
• 01: Full - Incremental (5785fab5)
• 00: Full (0481b203)

[PaulSandoz]

Copy the doc from the first method and add @see

[PaulSandoz]

Looks good, please address the doc comment before integrating.

Lets review the naming and follow up with another PR. I am inclined to think of this as embed and extract.

• quoteOp is renamed to embedOp, as in embeds an operation into its quoted form.
• quotedOp is renamed to extractOp, as in extracts an operation from its quoted form.
  That naming seems more evocative as to the mechanics.
  (Regardless of the names, both form an embedding-projection pair.)

[mabbay]

/integrate

[openjdk]

Going to push as commit 028d2bc.
Since your change was applied there have been 16 commits pushed to the code-reflection branch:

• 4a88aba: Rearrange lowering.
• c3b86bb: Stop intellij red-squiggling lambda parms called value
• 939aeaa: [samples] Apply type conversion for the int-shift function after the new result op has been built
• ... and 13 more: https://git.openjdk.org/babylon/compare/326717927244f691793cb11ffb2027c0175910a0...code-reflection

Your commit was automatically rebased without conflicts.

[openjdk]

@mabbay Pushed as commit 028d2bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.