8340393: Open source closed choice tests #2

[azvegint]

few manual tests to open source
Tested on all platforms, all looks good.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340393: Open source closed choice tests Make "can write" check work on Windows #2 (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21081/head:pull/21081
$ git checkout pull/21081

Update a local copy of the PR:
$ git checkout pull/21081
$ git pull https://git.openjdk.org/jdk.git pull/21081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21081

View PR using the GUI difftool:
$ git pr show -t 21081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21081.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340393: Open source closed choice tests #2

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 3ad6e31: 8340438: RISC-V: minor improvement in base64
• a50440f: 8340456: Reduce overhead of proxying Object methods in ProxyGenerator
• 5d611c0: 8340439: AArch64: Extra entry declaration for assember test
• 9d76c7c: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely
• 46b02f4: 8339906: Open source several AWT focus tests - series 4
• f4e4017: 8339984: Open source AWT MenuItem related tests
• 0f7d9e5: 8340436: Remove unused CompressedOops::AnyNarrowOopMode
• 94c3317: 8339895: Open source several AWT focus tests - series 3
• 969c2af: 8339192: Native annotation parsing code of deprecated annotations causes crash
• fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902
• ... and 31 more: https://git.openjdk.org/jdk/compare/aeba1ea7c44d6b378decf8557c8cd9fc7bfb7df5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (964075ea)
• 01: Full - Incremental (29851a72)
• 00: Full (fecc2f8c)

[prsadhuk]

I guess it was decided that java.awt will come before javax.swing...

[azvegint]

updated.

[prsadhuk]

Shouldn't it be "Enable checkbox"?

[azvegint]

I would read the "Enable checkbox" as somehow related to setEnabled, but the component is already enabled.
So I'll keep it as it is.

[prsadhuk]

As per Checkbox spec
"A check box is a graphical component that can be in either an "on" (true) or "off" (false) state"
so I guess "Switch on checkbox" would be more apt.. To me atleast, "switch checkbox" doesn't sound perfect...

[azvegint]

It is off by default in this test, so "switch" will set it to the desired selected state. So it should be OK.
Anyway, updated to the "Select the checkbox"