JDK-8340077 : Open source few Checkbox tests - Set2

[honkar-jdk]

Following tests are updated in this PR:

1. test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java
2. test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java
3. test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java
4. test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340077: Open source few Checkbox tests - Set2 (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21094/head:pull/21094
$ git checkout pull/21094

Update a local copy of the PR:
$ git checkout pull/21094
$ git pull https://git.openjdk.org/jdk.git pull/21094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21094

View PR using the GUI difftool:
$ git pr show -t 21094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21094.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340077: Open source few Checkbox tests - Set2

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

• 0f7d9e5: 8340436: Remove unused CompressedOops::AnyNarrowOopMode
• 94c3317: 8339895: Open source several AWT focus tests - series 3
• 969c2af: 8339192: Native annotation parsing code of deprecated annotations causes crash
• fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902
• 296b496: 8340353: Remove CompressedOops::ptrs_base
• fde8508: 8339902: Open source couple TextField related tests
• 75d5e11: 8340400: Shenandoah: Whitebox breakpoint GC requests may cause assertions
• 15ae115: 8340166: [REDO] CDS: Trim down minimum GC region alignment
• ec3cba0: 8340399: Update comment in SourceVersion for language evolution history
• d1d8240: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
• ... and 156 more: https://git.openjdk.org/jdk/compare/f0e84b7617aebc421483f36bb7d0b14d0fc39616...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fd311363)

[honkar-jdk]

@prsadhuk Tested at different UI Scales on windows and "the box" doesn't seem to scale properly and doesn't match windows native app (used Word -> Font settings to check).
I think it is product bug. These tests weren't problemlisted so I may need to create a new JBS bug and problemlist this test and probably CheckboxIndicatorSizeTest on windows.

[prsadhuk]

Looks to be similar to JDK-8233068

[honkar-jdk]

@prsadhuk Thanks for linking the issue. Yes it looks to be similar.
Unlike XCheckboxPeer.java, WCheckboxPeer.java does not have paintCheckbox(), it is probably done somewhere else for windows.