Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340438: RISC-V: minor improvement in base64 #21105

Closed

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Sep 20, 2024

Hi,
Can you help to review this simple patch?
Thanks

Thanks @RealFYang for spotting this!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340438: RISC-V: minor improvement in base64 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21105/head:pull/21105
$ git checkout pull/21105

Update a local copy of the PR:
$ git checkout pull/21105
$ git pull https://git.openjdk.org/jdk.git pull/21105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21105

View PR using the GUI difftool:
$ git pr show -t 21105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21105.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340438: RISC-V: minor improvement in base64

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@Hamlin-Li
Copy link
Author

Thanks for your reviewing! @RealFYang

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

Going to push as commit 3ad6e31.
Since your change was applied there have been 25 commits pushed to the master branch:

  • a50440f: 8340456: Reduce overhead of proxying Object methods in ProxyGenerator
  • 5d611c0: 8340439: AArch64: Extra entry declaration for assember test
  • 9d76c7c: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely
  • 46b02f4: 8339906: Open source several AWT focus tests - series 4
  • f4e4017: 8339984: Open source AWT MenuItem related tests
  • 0f7d9e5: 8340436: Remove unused CompressedOops::AnyNarrowOopMode
  • 94c3317: 8339895: Open source several AWT focus tests - series 3
  • 969c2af: 8339192: Native annotation parsing code of deprecated annotations causes crash
  • fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902
  • 296b496: 8340353: Remove CompressedOops::ptrs_base
  • ... and 15 more: https://git.openjdk.org/jdk/compare/8908812d0a64f25f0d033d44725a69348789b223...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2024
@openjdk openjdk bot closed this Sep 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@Hamlin-Li Pushed as commit 3ad6e31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants