-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8343157: Examine large files for character encoding/decoding #24597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/label core-libs,nio |
@naotoj The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to delete, no real value keeping these.
Thanks for the review! |
Going to push as commit d748bb5.
Your commit was automatically rebased without conflicts. |
Removing old charset test cases that verify new charset implementations (as of JDK7). Removed tests/files are actual charset implementations used in pre-JDK7, which have been used for comparing the results. Since those "new" implementations have been used since then, I believe it is OK to retire those old test cases.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24597/head:pull/24597
$ git checkout pull/24597
Update a local copy of the PR:
$ git checkout pull/24597
$ git pull https://git.openjdk.org/jdk.git pull/24597/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24597
View PR using the GUI difftool:
$ git pr show -t 24597
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24597.diff
Using Webrev
Link to Webrev Comment