Skip to content

8343157: Examine large files for character encoding/decoding #24597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Apr 11, 2025

Removing old charset test cases that verify new charset implementations (as of JDK7). Removed tests/files are actual charset implementations used in pre-JDK7, which have been used for comparing the results. Since those "new" implementations have been used since then, I believe it is OK to retire those old test cases.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343157: Examine large files for character encoding/decoding (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24597/head:pull/24597
$ git checkout pull/24597

Update a local copy of the PR:
$ git checkout pull/24597
$ git pull https://git.openjdk.org/jdk.git pull/24597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24597

View PR using the GUI difftool:
$ git pr show -t 24597

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24597.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343157: Examine large files for character encoding/decoding

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2025
@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@naotoj The following label will be automatically applied to this pull request:

  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 11, 2025

Webrevs

@naotoj
Copy link
Member Author

naotoj commented Apr 11, 2025

/label core-libs,nio

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@naotoj
The core-libs label was successfully added.

The nio label was successfully added.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to delete, no real value keeping these.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2025
@naotoj
Copy link
Member Author

naotoj commented Apr 14, 2025

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Apr 14, 2025

Going to push as commit d748bb5.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 14, 2025
@openjdk openjdk bot closed this Apr 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 14, 2025
@openjdk
Copy link

openjdk bot commented Apr 14, 2025

@naotoj Pushed as commit d748bb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants