8353655: Clean up and open source KeyEvent related tests (Part 1) #24609

azuev-java · 2025-04-13T03:29:37Z

Clean up and open source three tests related to the KeyEvent mechanics.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8353655: Clean up and open source KeyEvent related tests (Part 1) (Bug - P4)

Reviewers

Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24609/head:pull/24609
$ git checkout pull/24609

Update a local copy of the PR:
$ git checkout pull/24609
$ git pull https://git.openjdk.org/jdk.git pull/24609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24609

View PR using the GUI difftool:
$ git pr show -t 24609

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24609.diff

Using Webrev

Link to Webrev Comment

Clean up and open source three tests related to the KeyEvent mechanics.

bridgekeeper · 2025-04-13T03:30:18Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-13T03:30:41Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353655: Clean up and open source KeyEvent related tests (Part 1)

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 457 new commits pushed to the master branch:

1b4b317: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer
7b06188: 8354464: Additional cleanup setting up native.encoding
4eae9b5: 8354541: Remove Shenandoah post barrier expand loop opts
... and 454 more: https://git.openjdk.org/jdk/compare/a8757332667df3fe41a29a7eedb2a7234d23c2a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-13T03:31:16Z

@azuev-java The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-13T03:34:48Z

Webrevs

kumarabhi006 · 2025-04-14T11:17:43Z

test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java

+                .build()
+                .awaitAndCheck();
+    }
+}


Blank line after this ?

kumarabhi006 · 2025-04-14T11:17:55Z

test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java

+/*
+ * @test
+ * @bug 4308606
+ * @summary   Tests whether the keys on the numeric keyboard work


Suggested change

* @summary Tests whether the keys on the numeric keyboard work

* @summary Tests whether the keys on the numeric keyboard work

kumarabhi006 · 2025-04-14T11:21:18Z

test/jdk/java/awt/event/KeyEvent/HomeEndKeyTest.java

+        case KeyEvent.KEY_TYPED:
+            str = "KEY_TYPED";
+            break;


printKey is not invoked from keyTyped method and this case statement won't be reachable. Can be removed safely.

turbanoff · 2025-04-14T11:25:04Z

test/jdk/java/awt/event/KeyEvent/NumpadTest.java

+    }
+
+    protected void printKey(KeyEvent evt) {
+        switch(evt.getID()) {


Suggested change

switch(evt.getID()) {

switch (evt.getID()) {

test/jdk/java/awt/event/KeyEvent/HomeEndKeyTest.java

kumarabhi006

LGTM

test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java

Co-authored-by: Andrey Turbanov <[email protected]>

azuev-java · 2025-04-17T16:23:04Z

/integrate

openjdk · 2025-04-17T16:24:18Z

@azuev-java This pull request has not yet been marked as ready for integration.

kumarabhi006 · 2025-04-17T19:37:24Z

@azuev-java This PR is not integrated but the JBS issue is closed now.

azuev-java · 2025-04-17T19:53:22Z

/integrate

openjdk · 2025-04-17T19:53:50Z

Going to push as commit ad7c475.
Since your change was applied there have been 457 commits pushed to the master branch:

1b4b317: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer
7b06188: 8354464: Additional cleanup setting up native.encoding
4eae9b5: 8354541: Remove Shenandoah post barrier expand loop opts
... and 454 more: https://git.openjdk.org/jdk/compare/a8757332667df3fe41a29a7eedb2a7234d23c2a0...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-17T19:53:57Z

@azuev-java Pushed as commit ad7c475.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8353655: Clean up and open source KeyEvent related tests (Part 1)

af6ca77

Clean up and open source three tests related to the KeyEvent mechanics.

openjdk bot added the rfr Pull request is ready for review label Apr 13, 2025

openjdk bot added the client [email protected] label Apr 13, 2025

kumarabhi006 reviewed Apr 14, 2025

View reviewed changes

turbanoff reviewed Apr 14, 2025

View reviewed changes

test/jdk/java/awt/event/KeyEvent/HomeEndKeyTest.java Outdated Show resolved Hide resolved

Small fixes based on review comments

b876163

kumarabhi006 approved these changes Apr 16, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2025

prrace reviewed Apr 16, 2025

View reviewed changes

test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java Show resolved Hide resolved

azuev-java and others added 2 commits April 17, 2025 09:21

Add i18n key

dfc3b8f

Update test/jdk/java/awt/event/KeyEvent/HomeEndKeyTest.java

8e0c9e9

Co-authored-by: Andrey Turbanov <[email protected]>

openjdk bot removed the ready Pull request is ready to be integrated label Apr 17, 2025

kumarabhi006 approved these changes Apr 17, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025

openjdk bot closed this Apr 17, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2025

	* @summary Tests whether the keys on the numeric keyboard work
	* @summary Tests whether the keys on the numeric keyboard work

8353655: Clean up and open source KeyEvent related tests (Part 1) #24609

8353655: Clean up and open source KeyEvent related tests (Part 1) #24609

Uh oh!

Conversation

azuev-java commented Apr 13, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 13, 2025

Uh oh!

openjdk bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 13, 2025

Uh oh!

mlbridge bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

kumarabhi006 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

azuev-java Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

azuev-java Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

turbanoff Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kumarabhi006 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azuev-java commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

kumarabhi006 commented Apr 17, 2025

Uh oh!

azuev-java commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

Uh oh!

azuev-java commented Apr 13, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 13, 2025 •

edited

Loading

mlbridge bot commented Apr 13, 2025 •

edited

Loading