Skip to content

8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

vy
Copy link
Contributor

@vy vy commented May 2, 2025

Replaces os.name checks in tests with @requires. This prevents these tests from being run, and superficial results being generated, on unnecessary platforms.

Note that os.name checks are replaced with os.family instead.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value (Sub-task - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24997/head:pull/24997
$ git checkout pull/24997

Update a local copy of the PR:
$ git checkout pull/24997
$ git pull https://git.openjdk.org/jdk.git pull/24997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24997

View PR using the GUI difftool:
$ git pr show -t 24997

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24997.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2025

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2025
@openjdk
Copy link

openjdk bot commented May 2, 2025

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 2, 2025

Webrevs

@vy
Copy link
Contributor Author

vy commented May 7, 2025

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@vy
Your change (at version 242f078) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented May 7, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented May 7, 2025

Going to push as commit 60a4594.
Since your change was applied there have been 82 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2025
@openjdk openjdk bot closed this May 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@dfuch @vy Pushed as commit 60a4594.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants