FloatingDecimal add final and use record #24999
Draft
+9
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FloatingDecimal, the inner class PreparedASCIIToBinaryBuffer can be simplified with record, BinaryToASCIIBuffer can be added with final, and the fields isNegative/decExponent/digits of ASCIIToBinaryBuffer can be added with final.
Adding these is a better coding style, and it can also allow JIT to make more optimizations.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24999/head:pull/24999
$ git checkout pull/24999
Update a local copy of the PR:
$ git checkout pull/24999
$ git pull https://git.openjdk.org/jdk.git pull/24999/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24999
View PR using the GUI difftool:
$ git pr show -t 24999
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24999.diff