-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8356080: Address post-integration comments for Stable Values #25004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
/csr |
❗ This change is not yet ready to be integrated. |
|
@minborg has indicated that a compatibility and specification (CSR) request is needed for this pull request. @minborg please create a CSR request for issue JDK-8356080 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
This PR proposes to address comments in the initial PR for Stable Values, which were deferred until after integration.
Unfortunately, this PR shows the total commit history for stable values.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25004/head:pull/25004
$ git checkout pull/25004
Update a local copy of the PR:
$ git checkout pull/25004
$ git pull https://git.openjdk.org/jdk.git pull/25004/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25004
View PR using the GUI difftool:
$ git pr show -t 25004
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25004.diff
Using Webrev
Link to Webrev Comment