Skip to content

8356080: Address post-integration comments for Stable Values #25004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 382 commits into
base: master
Choose a base branch
from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented May 2, 2025

This PR proposes to address comments in the initial PR for Stable Values, which were deferred until after integration.

Unfortunately, this PR shows the total commit history for stable values.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8356081 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8356080: Address post-integration comments for Stable Values (Bug - P4)
  • JDK-8356081: Address post-integration comments for Stable Values (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25004/head:pull/25004
$ git checkout pull/25004

Update a local copy of the PR:
$ git checkout pull/25004
$ git pull https://git.openjdk.org/jdk.git pull/25004/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25004

View PR using the GUI difftool:
$ git pr show -t 25004

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25004.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2025

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@minborg
Copy link
Contributor Author

minborg commented May 2, 2025

/csr

@openjdk
Copy link

openjdk bot commented May 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 2, 2025

⚠️ @minborg This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 2, 2025
@openjdk
Copy link

openjdk bot commented May 2, 2025

@minborg has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@minborg please create a CSR request for issue JDK-8356080 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented May 2, 2025

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label May 5, 2025
@minborg minborg marked this pull request as ready for review May 6, 2025 08:59
@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2025
@mlbridge
Copy link

mlbridge bot commented May 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

5 participants