8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out

[justin-curtis-lu]

Please review this PR which reduces the amount of combinations tested by LocaleNameProviderTest.

This test was exhaustively testing over 1000x1000 Locale combinations which was expensive and caused a timeout in tier 5. Narrowing down the tested locales to Japanese language ones can reduce our tested input to 9x9 and provides most of the same value the test previously did. (Since our SPI provider has defined preferred Japanese Locale name values.) This change also refactors the test to use JUnit. The test now runs around ~20 times faster.

Most of the diff is attributed to separating the method source from the test itself. But notice the filtering of Locales done on availloc and jreImplLoc.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25009/head:pull/25009
$ git checkout pull/25009

Update a local copy of the PR:
$ git checkout pull/25009
$ git pull https://git.openjdk.org/jdk.git pull/25009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25009

View PR using the GUI difftool:
$ git pr show -t 25009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25009.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 56468c4: 8322810: Lambda expression types can't be classes
• 60ba81d: 8354347: Increase the default padding size for aarch64 in JDK code.
• c8bbcaf: 8348638: Performance regression in Math.tanh
• ... and 18 more: https://git.openjdk.org/jdk/compare/394961c8fe87da7376cc7522580cd4ac104c3cf5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (579c1ebe)
• 00: Full (c3e77cde)

[naotoj]

Looks good.

[naotoj]

It would be helpful to mention why CLDR is not the preferred provider (as the SPI impl has variants of the Japanese locale)

[naotoj]

Can be replaced with isEmpty()

[naotoj]

LGTM. Thanks for simplifying the test

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit 32f67a3.
Since your change was applied there have been 38 commits pushed to the master branch:

• f687644: 8356153: Shenandoah stubs are missing in AOT Code Cache addresses table
• 6719b92: 8356108: Update SourceVersion.RELEASE_25 description for JEPs 511 and 512
• 1501a5e: 8356122: Client build fails after JDK-8350209
• ... and 35 more: https://git.openjdk.org/jdk/compare/394961c8fe87da7376cc7522580cd4ac104c3cf5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 32f67a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.