Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 23, 2025

The test com/sun/nio/sctp/SctpChannel/CloseDescriptors.java observed intermittent fails. Before the root cause of failure has been fixed, should we mark this test @key intermittent, to make some setups skip this test or re-run this test when it's fails.

After the failure root cause has been fixed, we should remove the @key intermittent in test definition.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366031: Mark com/sun/nio/sctp/SctpChannel/CloseDescriptors.java as intermittent (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26910/head:pull/26910
$ git checkout pull/26910

Update a local copy of the PR:
$ git checkout pull/26910
$ git pull https://git.openjdk.org/jdk.git pull/26910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26910

View PR using the GUI difftool:
$ git pr show -t 26910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26910.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 23, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added nio [email protected] rfr Pull request is ready for review labels Aug 23, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2025

Webrevs

@AlanBateman
Copy link
Contributor

/label nio remove
/label net add

@openjdk
Copy link

openjdk bot commented Aug 24, 2025

@AlanBateman
The label remove is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@openjdk
Copy link

openjdk bot commented Aug 24, 2025

@AlanBateman
The label add is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@AlanBateman
Copy link
Contributor

/label remove nio
/label add net

@openjdk
Copy link

openjdk bot commented Aug 24, 2025

@AlanBateman
The nio label was successfully removed.

@openjdk openjdk bot added net [email protected] and removed rfr Pull request is ready for review labels Aug 24, 2025
@openjdk
Copy link

openjdk bot commented Aug 24, 2025

@AlanBateman
The net label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants