-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365442: [asan] runtime/ErrorHandling/CreateCoredumpOnCrash.java fails #26927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's because asan uses 20TiB of virtual address space? I'm OK with this being disabled on asan.
Thanks for the review ! /integrate |
Going to push as commit e5ec464.
Your commit was automatically rebased without conflicts. |
Thanks for fixing it :). Could you please wait 24 hours after opening the PR and wait for a 2nd reviewer before integrating next time? I wasn't sure if this was actually trivial, and we want all time zones to get a chance to look at a PR before it goes in. |
When running with asan - enabled binaries, the test CreateCoredumpOnCrash.java fails with the output below. Seems asan does not work well with ulimit used in the test, so better avoid running it with asan enabled.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26927/head:pull/26927
$ git checkout pull/26927
Update a local copy of the PR:
$ git checkout pull/26927
$ git pull https://git.openjdk.org/jdk.git pull/26927/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26927
View PR using the GUI difftool:
$ git pr show -t 26927
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26927.diff
Using Webrev
Link to Webrev Comment