Skip to content

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 25, 2025

When running with asan - enabled binaries, the test CreateCoredumpOnCrash.java fails with the output below. Seems asan does not work well with ulimit used in the test, so better avoid running it with asan enabled.


[2025-08-09T09:25:35.801707203Z] Gathering output for process 4376
[2025-08-09T09:25:41.863125073Z] Waiting for completion for process 4376
[2025-08-09T09:25:41.863790182Z] Waiting for completion finished for process 4376
[2025-08-09T09:25:41.876094199Z] Gathering output for process 5017
[2025-08-09T09:25:41.883445027Z] Waiting for completion for process 5017
[2025-08-09T09:25:41.883598661Z] Waiting for completion finished for process 5017
----------System.err:(10/570)----------
java.lang.Exception: ulimit is not set correctly, try 'ulimit -c unlimited' and re-run.
at CreateCoredumpOnCrash.main(CreateCoredumpOnCrash.java:82)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
at java.base/java.lang.Thread.run(Thread.java:1474)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365442: [asan] runtime/ErrorHandling/CreateCoredumpOnCrash.java fails (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26927/head:pull/26927
$ git checkout pull/26927

Update a local copy of the PR:
$ git checkout pull/26927
$ git pull https://git.openjdk.org/jdk.git pull/26927/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26927

View PR using the GUI difftool:
$ git pr show -t 26927

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26927.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365442: [asan] runtime/ErrorHandling/CreateCoredumpOnCrash.java fails

Reviewed-by: jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 040cc7a: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize()
  • d24449f: 8365815: JFR: Update metadata.xml with 'jfr query' examples

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8365442: [asan] runtime/ErrorHandling/CreateCoredumpOnCrash.java fails 8365442: [asan] runtime/ErrorHandling/CreateCoredumpOnCrash.java fails Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime [email protected] rfr Pull request is ready for review labels Aug 25, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2025

Webrevs

Copy link
Contributor

@jdksjolen jdksjolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's because asan uses 20TiB of virtual address space? I'm OK with this being disabled on asan.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2025
@MBaesken
Copy link
Member Author

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

Going to push as commit e5ec464.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2025
@openjdk openjdk bot closed this Aug 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@MBaesken Pushed as commit e5ec464.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jdksjolen
Copy link
Contributor

Thanks for the review !

/integrate

Thanks for fixing it :). Could you please wait 24 hours after opening the PR and wait for a 2nd reviewer before integrating next time? I wasn't sure if this was actually trivial, and we want all time zones to get a chance to look at a PR before it goes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants