8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

[prrace]

The disposer for MemoryCacheImageInputStream isn't needed. All it does is clear an ArrayList of byte[]
GC can take care of that.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

Issue

• JDK-8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer. (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• Jayathirth D V (@jayathirthrao - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26933/head:pull/26933
$ git checkout pull/26933

Update a local copy of the PR:
$ git checkout pull/26933
$ git pull https://git.openjdk.org/jdk.git pull/26933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26933

View PR using the GUI difftool:
$ git pr show -t 26933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26933.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

Reviewed-by: psadhukhan, jdv, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 2b44ed7: 8365807: (fs) Two-arg UnixFileAttributes.getIfExists should not use exception for control flow
• 6a480ad: 8366126: Feedback on two errors in JSR 400
• caaef3a: 8350920: Allow inherited member summaries to be viewed inline
• ... and 34 more: https://git.openjdk.org/jdk/compare/603526b55b5e9b6dfc9323d2cdc4a0b4d0f88a49...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3b32319b)

[mrserb]

may be there are some hints in the history that suggest why it was initially added? or it might simply have been an overlooked misuse of the disposer?

[prrace]

may be there are some hints in the history that suggest why it was initially added? or it might simply have been an overlooked misuse of the disposer?

I think it was mostly a mis-use - partly because it could also flush() the stream and there wasn't sufficient thought given when converting from finalize() for this case a long time ago.
However as discussed in another PR, even for output, if you haven't flushed the stream a lot earlier than this you are too late now.
And for input I can't see any issue

[prrace]

/integrate

[openjdk]

Going to push as commit c755345.
Since your change was applied there have been 38 commits pushed to the master branch:

• c203e70: 8366037: Remove oopDesc::mark_addr()
• 2b44ed7: 8365807: (fs) Two-arg UnixFileAttributes.getIfExists should not use exception for control flow
• 6a480ad: 8366126: Feedback on two errors in JSR 400
• ... and 35 more: https://git.openjdk.org/jdk/compare/603526b55b5e9b6dfc9323d2cdc4a0b4d0f88a49...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit c755345.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.