8369622: GlobalChunkPoolMutex is recursively locked during error handling

[coleenp]

This change disables recursive locking for the ChunkPoolLocker during error handling for NMT callers. The patch is written by Johan as an alternative to supporting another recursive locker for this lock.
Tested with tier1-4, tier5 on aarch64 (product and debug).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369622: GlobalChunkPoolMutex is recursively locked during error handling (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Contributors

• Johan Sjölen <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27869/head:pull/27869
$ git checkout pull/27869

Update a local copy of the PR:
$ git checkout pull/27869
$ git pull https://git.openjdk.org/jdk.git pull/27869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27869

View PR using the GUI difftool:
$ git pr show -t 27869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27869.diff

Using Webrev

Link to Webrev Comment

[coleenp]

/contributor add @jdksjolen

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369622: GlobalChunkPoolMutex is recursively locked during error handling

Co-authored-by: Johan Sjölen <[email protected]>
Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• c2fde51: 8357390: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java Test failing on Ubuntu 24.04 Vm Hosts used by Oracle's internal CI system
• eff6439: 8370120: Make jpackage tests output more stable
• b0af41d: 8370134: Fix minor jpackage issues
• ... and 57 more: https://git.openjdk.org/jdk/compare/c9cbd31f8575a25c4decd68dc645378c5ba2bad0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp
Contributor Johan Sjölen <[email protected]> successfully added.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9a27e598)

[dholmes-ora]

This is the same kind of strategy used by ZGC. It seems a good idiom to use for dealing with error reporting.

Looks good.

Thanks

[dholmes-ora]

Thinking more, we could simply always do this check in the constructor and do away with the "strategy" flag altogether. Arguably this would be reasonable behaviour for every Mutexlocker (though it may slow things down a little).

[coleenp]

I had a version that did this but Johan was worried about global behavior so wanted to limit it to just NMT reporting on error to be safe.