Skip to content

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Oct 17, 2025

Assorted updates to jpackage test lib:

  • Use --release 11 javac option to compile test app. This allows custom runtimes created from older JDKs to be used. Using external runtimes allows to avoid jpackage running jlink in every test and saves time in local tests. With this change, creating a single stub runtime and using it with jpackage tests across multiple releases is possible.
  • Add "JUnitUtils" helper.
  • Add "ObjectMapper" class that converts a given object into a property map (Map<String, Object>). Handy to create a dump of object hierarchies.
  • Add "ConfigurationTarget" class to simplify applying the same initializers when testing app image and native package bundling.
  • Fix "AppImagePackageTest" test to make it produce a valid macOS bundle to leverage the default verification of jpackage output in the jpackage test lib.
  • Add test cases for the main/additional launcher descriptions to AddLauncherTest test.
  • Add validation of the "Comment" key value in Linux .desktop files.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8370122: jpackage test lib improvements

Issue

  • JDK-8370122: jpackage test lib improvements (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27872/head:pull/27872
$ git checkout pull/27872

Update a local copy of the PR:
$ git checkout pull/27872
$ git pull https://git.openjdk.org/jdk.git pull/27872/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27872

View PR using the GUI difftool:
$ git pr show -t 27872

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27872.diff

Using Webrev

Link to Webrev Comment

@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as draft October 17, 2025 17:42
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370122: jpackage test lib improvements

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review October 18, 2025 02:54
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as draft October 18, 2025 02:55
@alexeysemenyukoracle alexeysemenyukoracle force-pushed the JDK-8370122 branch 2 times, most recently from 7139b61 to 93b6661 Compare October 20, 2025 16:06
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review October 20, 2025 17:05
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev PTAL

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor typo.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2025
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 22, 2025

Going to push as commit 94c0611.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 22, 2025
@openjdk openjdk bot closed this Oct 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2025
@openjdk
Copy link

openjdk bot commented Oct 22, 2025

@alexeysemenyukoracle Pushed as commit 94c0611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants