-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370122: jpackage test lib improvements #27872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8370122: jpackage test lib improvements #27872
Conversation
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
7139b61
to
93b6661
Compare
@sashamatveev PTAL |
93b6661
to
3bc40fe
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
3bc40fe
to
58f206b
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
…uncherIconVerifier: make setters unambiguous; Add ConfigurationTarget
…he default verification of jpackage output in jpackage test lib.
…use by CompositeProxy
58f206b
to
cad3e78
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with minor typo.
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/ObjectMapper.java
Outdated
Show resolved
Hide resolved
/integrate |
Going to push as commit 94c0611.
Your commit was automatically rebased without conflicts. |
@alexeysemenyukoracle Pushed as commit 94c0611. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Assorted updates to jpackage test lib:
--release 11
javac option to compile test app. This allows custom runtimes created from older JDKs to be used. Using external runtimes allows to avoid jpackage running jlink in every test and saves time in local tests. With this change, creating a single stub runtime and using it with jpackage tests across multiple releases is possible.Map<String, Object>
). Handy to create a dump of object hierarchies.Progress
Warning
8370122: jpackage test lib improvements
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27872/head:pull/27872
$ git checkout pull/27872
Update a local copy of the PR:
$ git checkout pull/27872
$ git pull https://git.openjdk.org/jdk.git pull/27872/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27872
View PR using the GUI difftool:
$ git pr show -t 27872
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27872.diff
Using Webrev
Link to Webrev Comment