8367976: Validate and clamp jdk.httpclient.bufsize

[vy]

Validate and clamp the value populated from the jdk.httpclient.bufsize system property. Added two new tests: Does clamping work? Does the minimum value wedge the client?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367976: Validate and clamp jdk.httpclient.bufsize (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27874/head:pull/27874
$ git checkout pull/27874

Update a local copy of the PR:
$ git checkout pull/27874
$ git pull https://git.openjdk.org/jdk.git pull/27874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27874

View PR using the GUI difftool:
$ git pr show -t 27874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27874.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367976: Validate and clamp jdk.httpclient.bufsize

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• bdfd5e8: 8367690: C2: Unneeded branch in reduce_phi
• 6bf3581: 8369946: Bytecode rewriting causes Java heap corruption on PPC
• 27c83c7: 8370225: RISC-V: cleanup verify_xxx in interp_masm_riscv.hpp
• ... and 23 more: https://git.openjdk.org/jdk/compare/ec13c283c48c37e80d6c9c2753b09b31f4d14734...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 07: Full - Incremental (e1a89493)
• 06: Full - Incremental (ab7695ec)
• 05: Full - Incremental (b9186533)
• 04: Full - Incremental (92f07382)
• 03: Full - Incremental (26fdcb4a)
• 02: Full - Incremental (0cd7deef)
• 01: Full - Incremental (148d4268)
• 00: Full (67133467)

[dfuch]

You will also need to update module-info.java where the property is documented, to indicate what is the range of valid values and what happens if an invalid value is provided.

https://github.com/openjdk/jdk/blob/8c775e299dbf651c3be1ba84b9e50356a3503861/src/java.net.http/share/classes/module-info.java#L49C1-L52C9

[vy]

You will also need to update module-info.java

Implemented in 148d426. I presume this warrants a CSR, right?

[dfuch]

It's an implementation specific property - so not part of the Java SE specification. IMO it was a bug that we didn't clamp it in the first place. There's no real change in observable behaviour here. I am not sure we actually need a CSR.

[openjdk]

@vy Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[dfuch]

LGTM

[vy]

@dfuch, thanks so much for the review feedback – it, as always, certainly helped.

Tier 1-2 is clear on several platforms.

/integrate

[openjdk]

Going to push as commit cbbb0a8.
Since your change was applied there have been 29 commits pushed to the master branch:

• 763d425: 8368781: PerfMemory - make issues more transparent
• 6010457: 8370378: Some compiler tests inadvertently exclude particular platforms
• b8d3c90: 8370229: Remove unused method declarations after JDK-8322630
• ... and 26 more: https://git.openjdk.org/jdk/compare/ec13c283c48c37e80d6c9c2753b09b31f4d14734...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vy Pushed as commit cbbb0a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.