8370057: Correct scale handling of BigDecimal.sqrt

[jddarcy]

Correct scale handling of BigDecimal.sqrt to conform to IEEE 754.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8370151 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8370057: Correct scale handling of BigDecimal.sqrt (Bug - P4)
• JDK-8370151: Correct scale handling of BigDecimal.sqrt (CSR)

Reviewers

• Raffaello Giulietti (@rgiulietti - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27882/head:pull/27882
$ git checkout pull/27882

Update a local copy of the PR:
$ git checkout pull/27882
$ git pull https://git.openjdk.org/jdk.git pull/27882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27882

View PR using the GUI difftool:
$ git pr show -t 27882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27882.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370057: Correct scale handling of BigDecimal.sqrt

Reviewed-by: rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• 869112e: 8026776: Broken API names in API doc
• 6e898e2: 8369944: Notification can be lost due to interrupt in Object.wait
• aaa9fbf: 8368365: ASAN errors should produce hs-err files and core dumps
• ... and 80 more: https://git.openjdk.org/jdk/compare/0cc88e4ad4ded970433eed25778a7290ddf9b0fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (aa5d60fe)
• 00: Full (23936495)

[rgiulietti]

In the test, starting here, there's a comment about an algorithm presented in a paper.

Is it still relevant?

[rgiulietti]

Test copyright year

[jddarcy]

In the test, starting here, there's a comment about an algorithm presented in a paper.

Is it still relevant?

Yes; that comment still describes the alternative algorithm used in the test.

[rgiulietti]

Looks fine.

[jddarcy]

/integrate

[openjdk]

Going to push as commit a0e0b2d.
Since your change was applied there have been 83 commits pushed to the master branch:

• 869112e: 8026776: Broken API names in API doc
• 6e898e2: 8369944: Notification can be lost due to interrupt in Object.wait
• aaa9fbf: 8368365: ASAN errors should produce hs-err files and core dumps
• ... and 80 more: https://git.openjdk.org/jdk/compare/0cc88e4ad4ded970433eed25778a7290ddf9b0fa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit a0e0b2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.