-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372125: containers/docker/TestPids.java fails after 8365606 #28383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
caspernorrbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
/issue JDK-8372125 |
|
@sendaoYan This issue is referenced in the PR title - it will now be updated. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi all,
The test containers/docker/TestPids.java seems to be fails after JDK-8365606
I think max/-1/ulimited are all acceptable as unlimited pids value.
The change has been verified locally on linux-x64 and linux-aarch64.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28383/head:pull/28383$ git checkout pull/28383Update a local copy of the PR:
$ git checkout pull/28383$ git pull https://git.openjdk.org/jdk.git pull/28383/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28383View PR using the GUI difftool:
$ git pr show -t 28383Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28383.diff
Using Webrev
Link to Webrev Comment