Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 19, 2025

Hi all,

The test containers/docker/TestPids.java seems to be fails after JDK-8365606
I think max/-1/ulimited are all acceptable as unlimited pids value.
The change has been verified locally on linux-x64 and linux-aarch64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372125: containers/docker/TestPids.java fails after 8365606 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28383/head:pull/28383
$ git checkout pull/28383

Update a local copy of the PR:
$ git checkout pull/28383
$ git pull https://git.openjdk.org/jdk.git pull/28383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28383

View PR using the GUI difftool:
$ git pr show -t 28383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28383.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372125: containers/docker/TestPids.java fails after 8365606

Reviewed-by: cnorrbin, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

Copy link
Member

@caspernorrbin caspernorrbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sendaoYan
Copy link
Member Author

/issue JDK-8372125

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@sendaoYan This issue is referenced in the PR title - it will now be updated.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants