8372162: G1: Merge subclasses of G1IHOPControl into parent class

[albertnetymk]

Merging two subclasses into the parent class to simplify type hierarchy. The internal bool flag doesn't introduce much complexity; instead, improves readability, IMO.

Perf neutral on linux-x64/aarch64: cachestree, dacapo, dacapo23, specjbb2005, specjbb2015, specjvm2008.

Test: tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372162: G1: Merge subclasses of G1IHOPControl into parent class (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28391/head:pull/28391
$ git checkout pull/28391

Update a local copy of the PR:
$ git checkout pull/28391
$ git pull https://git.openjdk.org/jdk.git pull/28391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28391

View PR using the GUI difftool:
$ git pr show -t 28391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28391.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372162: G1: Merge subclasses of G1IHOPControl into parent class

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• ad38a12: 8371557: java/net/httpclient/http3/H3RequestRejectedTest.java: javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict
• b41146c: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
• 6fc8e49: 8372097: C2: PhasePrintLevel requires setting PrintPhaseLevel explicitly to be active
• ... and 18 more: https://git.openjdk.org/jdk/compare/54893dc5c2a4702896029b1844bc9496325c8f26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (020abff5)

[tschatzl]

Seems good.

[walulyai]

Looks good!

Fix title after triage changed it

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 018284d.
Since your change was applied there have been 48 commits pushed to the master branch:

• d01e7d9: 8371783: Refactor GCCause in VM_CollectForMetadataAllocation
• 30410fe: 8333871: Check return values of sysinfo
• d57fc1b: 8372135: clang compilation error
• ... and 45 more: https://git.openjdk.org/jdk/compare/54893dc5c2a4702896029b1844bc9496325c8f26...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 018284d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.