Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Nov 19, 2025

Trivial comment fix in Character.UnicodeBlock


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372117: Correct the misleading comment in Character.UnicodeBlock (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28401/head:pull/28401
$ git checkout pull/28401

Update a local copy of the PR:
$ git checkout pull/28401
$ git pull https://git.openjdk.org/jdk.git pull/28401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28401

View PR using the GUI difftool:
$ git pr show -t 28401

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28401.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372117: Correct the misleading comment in Character.UnicodeBlock

Reviewed-by: bpb, joehw, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2025
@naotoj
Copy link
Member Author

naotoj commented Nov 20, 2025

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

Going to push as commit 41d6dc3.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2025
@openjdk openjdk bot closed this Nov 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2025
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@naotoj Pushed as commit 41d6dc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants