8387078: RISC-V: x27 can be allocated in CompressedOops mode#31627
8387078: RISC-V: x27 can be allocated in CompressedOops mode#31627zzthread wants to merge 1 commit into
Conversation
|
Hi @zzthread, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zzthread" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
| // x27 is not allocatable when compressed oops is on | ||
| if (UseCompressedOops) { | ||
| // x27 is not allocatable when compressed oops is on and heapbase is not zero | ||
| if (UseCompressedOops && (CompressedOops::base() != nullptr)) { |
There was a problem hiding this comment.
| if (UseCompressedOops && (CompressedOops::base() != nullptr)) { | |
| if (UseCompressedOops && CompressedOops::base() != nullptr) { |
Hi, we can see that the x27 register is used as the heapbase. If the heap is smaller than 32 GB, CompressedOops::base() is always 0, so in this case, we can provide an additional available register for C2.
Testing(SpacemiT Key Stone K3)
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31627/head:pull/31627$ git checkout pull/31627Update a local copy of the PR:
$ git checkout pull/31627$ git pull https://git.openjdk.org/jdk.git pull/31627/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31627View PR using the GUI difftool:
$ git pr show -t 31627Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31627.diff