Skip to content

8387078: RISC-V: x27 can be allocated in CompressedOops mode#31627

Open
zzthread wants to merge 1 commit into
openjdk:masterfrom
zzthread:JDK-8387078
Open

8387078: RISC-V: x27 can be allocated in CompressedOops mode#31627
zzthread wants to merge 1 commit into
openjdk:masterfrom
zzthread:JDK-8387078

Conversation

@zzthread

@zzthread zzthread commented Jun 23, 2026

Copy link
Copy Markdown

Hi, we can see that the x27 register is used as the heapbase. If the heap is smaller than 32 GB, CompressedOops::base() is always 0, so in this case, we can provide an additional available register for C2.

Testing(SpacemiT Key Stone K3)

  • tier1-3 tests (release)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8387078: RISC-V: x27 can be allocated in CompressedOops mode (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31627/head:pull/31627
$ git checkout pull/31627

Update a local copy of the PR:
$ git checkout pull/31627
$ git pull https://git.openjdk.org/jdk.git pull/31627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31627

View PR using the GUI difftool:
$ git pr show -t 31627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31627.diff

@zzthread zzthread marked this pull request as ready for review June 23, 2026 08:56
@bridgekeeper bridgekeeper Bot added the oca Needs verification of OCA signatory status label Jun 23, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

Hi @zzthread, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zzthread" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 23, 2026
@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

@zzthread The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 23, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@zzthread

Copy link
Copy Markdown
Author

/covered

@bridgekeeper bridgekeeper Bot added the oca-verify Needs verification of OCA signatory status label Jun 23, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

// x27 is not allocatable when compressed oops is on
if (UseCompressedOops) {
// x27 is not allocatable when compressed oops is on and heapbase is not zero
if (UseCompressedOops && (CompressedOops::base() != nullptr)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (UseCompressedOops && (CompressedOops::base() != nullptr)) {
if (UseCompressedOops && CompressedOops::base() != nullptr) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

2 participants