8387188: JImageExtractTest.java test should deny APPEND_DATA ACL in testExtractToReadOnlyDir

[raneashay]

Before this patch, the test in testExtractToReadOnlyDir(), which
validates whether making jimage extract to a read-only directory results
in a failure, denied creating files but it did not deny creating
subdirectories. Although this does make jimage fail (and consequently,
make the test pass), this isn't completely correct for two reasons.

First, the test invocation ends up writing a series of empty
subdirectories, when in reality we don't want the destination directory
to be modified at all. Second, and more importantly, this leaves these
directories in a state where Cygwin cannot remove them (see JBS issue
for more details).

This patch fixes the problem by adding APPEND_DATA to the deny list,
thus prohibiting the principal running the test from creating both files
as well as directories. This effectively sidesteps the issue of leaving
broken directories on disk.

See
https://learn.microsoft.com/en-us/windows/win32/fileio/file-access-rights-constants
for details about the file permissions, reproduced in part below:

FILE_WRITE_DATA: For a directory object, the right to create a file in
the directory.

FILE_APPEND_DATA: For a directory object, the right to create a
subdirectory.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8387188: JImageExtractTest.java test should deny APPEND_DATA ACL in testExtractToReadOnlyDir (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31646/head:pull/31646
$ git checkout pull/31646

Update a local copy of the PR:
$ git checkout pull/31646
$ git pull https://git.openjdk.org/jdk.git pull/31646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31646

View PR using the GUI difftool:
$ git pr show -t 31646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31646.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back arane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@raneashay The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b07fc7cc)