Skip to content

8386911: Crypto benchmark regressions after JDK-8384353#31648

Open
vpaprotsk wants to merge 8 commits into
openjdk:masterfrom
vpaprotsk:new-generatea
Open

8386911: Crypto benchmark regressions after JDK-8384353#31648
vpaprotsk wants to merge 8 commits into
openjdk:masterfrom
vpaprotsk:new-generatea

Conversation

@vpaprotsk

@vpaprotsk vpaprotsk commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

With quadKeccak, it is possible to have 3 extra keccaks calls that are really noops.. teach SHA3Parallel.squeeze() how many operations it really should be doing.

While it is possible to match precisely the number of keccak calls required.. the previous implementation always called doubleKeccak, so collapsing the odd numbers to the closest even.

PS: make install-hsdis test TEST="micro:org.openjdk.bench.javax.crypto.full.SignatureBench.MLDSA" MICRO="JAVA_OPTIONS=-XX:+UnlockDiagnosticVMOptions -XX:-UseSHA3Intrinsics;FORK=1;ITER=3;TIME=10;WARMUP_ITER=7;WARMUP_TIME=10;OPTIONS=-prof perfasm -p algorithm=ML-DSA-65"



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8386911: Crypto benchmark regressions after JDK-8384353 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31648/head:pull/31648
$ git checkout pull/31648

Update a local copy of the PR:
$ git checkout pull/31648
$ git pull https://git.openjdk.org/jdk.git pull/31648/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31648

View PR using the GUI difftool:
$ git pr show -t 31648

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31648.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 24, 2026

Copy link
Copy Markdown

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the security security-dev@openjdk.org label Jun 24, 2026
@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

@vpaprotsk The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vpaprotsk vpaprotsk marked this pull request as ready for review June 24, 2026 19:12
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 24, 2026
@mlbridge

mlbridge Bot commented Jun 24, 2026

Copy link
Copy Markdown

Webrevs

throw new InvalidAlgorithmParameterException("Bad parallel parameter.");
}

for (int i = 0; i < NRPAR; i++) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nr iterations is enough here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants