-
Notifications
You must be signed in to change notification settings - Fork 223
8136895: Writer not closed with disk full error, file resource leaked #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fixes bug with file writer leaking and not closing when encountering a disk full error. Applies cleanly. Patched in JDK22, and no known bugs from this change. New tests fail without the fix, and passes with it. Risk is low given the length of time in mainline and minor change. |
@cost0much |
@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Clean backport. Fixes bug with file writer leaking when encountering a disk full error. Passes new tests added on linux x64.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3475/head:pull/3475
$ git checkout pull/3475
Update a local copy of the PR:
$ git checkout pull/3475
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3475/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3475
View PR using the GUI difftool:
$ git pr show -t 3475
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3475.diff
Using Webrev
Link to Webrev Comment