-
Notifications
You must be signed in to change notification settings - Fork 223
8320276: Improve class initialization barrier in TemplateTable::_new #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Matt <[email protected]>
👋 Welcome back MattAlp! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
This is in support of #3317, see #3317 (comment) |
|
||
static void initialize_cpu_information(void); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong.
The original patch has a different change: openjdk/jdk@409a39e#diff-0e8cad40dc55410beb083852ab7a431d0c0cd668719b3c252c93c5083b824654R85-R94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, review the change to vm_version_ppc.hpp - it seems out of place.
For the rest of changes - I have verified they correspond to the original patch.
/label hotspot |
@jbachorik |
This PR backports 8320276 to support backporting 8338379, see the comment thread linked below. This was a clean backport, though reviewers may want to confirm that the decision to include this function was correct.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508
$ git checkout pull/3508
Update a local copy of the PR:
$ git checkout pull/3508
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3508
View PR using the GUI difftool:
$ git pr show -t 3508
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3508.diff
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508
$ git checkout pull/3508
Update a local copy of the PR:
$ git checkout pull/3508
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3508
View PR using the GUI difftool:
$ git pr show -t 3508
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3508.diff
Using Webrev
Link to Webrev Comment