Skip to content

8318915: Enhance checks in BigDecimal.toPlainString() #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 17, 2025

I backport this for parity with 17.0.16-oracle.

Fixed build. AbstractStringBuilder.repeat(...) is not in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8318915 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318915: Enhance checks in BigDecimal.toPlainString() (Enhancement - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3510/head:pull/3510
$ git checkout pull/3510

Update a local copy of the PR:
$ git checkout pull/3510
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3510

View PR using the GUI difftool:
$ git pr show -t 3510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3510.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the title Goetz backport 8318915 backport a6785e4d633908596ddb6de6d2eeab1c9ebdf2c3 Apr 17, 2025
@openjdk openjdk bot changed the title backport a6785e4d633908596ddb6de6d2eeab1c9ebdf2c3 8318915: Enhance checks in BigDecimal.toPlainString() Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 17, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 22, 2025

Thanks for the review!

@openjdk openjdk bot added the approval label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants