8320948: NPE due to unreported compiler error

[satyenme]

Backporting JDK-8320948: NPE due to unreported compiler error. The compiler decides not to report compiler error while doing recovery on deferred types - this fix looks into the speculative types of a deferred type and if all the speculative types are erroneous, then use a recovery type as the target type, which later on in the pipeline will imply reporting errors if any. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new test/langtools/tools/javac/recovery/CrashDueToUnreportedError.java tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320948 needs maintainer approval

Issue

• JDK-8320948: NPE due to unreported compiler error (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3521/head:pull/3521
$ git checkout pull/3521

Update a local copy of the PR:
$ git checkout pull/3521
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3521

View PR using the GUI difftool:
$ git pr show -t 3521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3521.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (dc71c046)

[satyenme]

/approval request for backport. The compiler decides not to report compiler error while doing recovery on deferred types - this fix looks into the speculative types of a deferred type and if all the speculative types are erroneous, then use a recovery type as the target type, which later on in the pipeline will imply reporting errors if any.

Risk: Medium. Tip change was merged in December 2023, touches compilation logic. Adds new test to help mitigate risk.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally
• New added test

[openjdk]

@satyenme
8320948: The approval request has been created successfully.