8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

[satyenme]

Backporting JDK-8314319: LogCompilation doesn't reset lateInlining when it encounters a failure. Fixes issue where compilation encounters a failure after it processes '<late_inline>' tag, and, in cases where the C2 compiler retries after tweaking options it omits subsume_load. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314319 needs maintainer approval

Warning

 ⚠️ Found trailing period in issue title for 8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

Issue

• JDK-8314319: LogCompilation doesn't reset lateInlining when it encounters a failure. (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3545/head:pull/3545
$ git checkout pull/3545

Update a local copy of the PR:
$ git checkout pull/3545
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3545

View PR using the GUI difftool:
$ git pr show -t 3545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3545.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change is no longer ready for integration - check the PR body for details.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (7878efe9)

[satyenme]

/approval request for backport. One line fix to address issue where compilation encounters a failure after it processes '<late_inline>' tag, and, in cases where the C2 compiler retries after tweaking options, it omits subsume_load

Risk: Low. Tip change was merged in September 2023 and PR adds a test to confirm functionality.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally
• src/utils/LogCompilation/src/test/java/com/sun/hotspot/tools/compiler/TestPrebuiltLogs.java

[openjdk]

@satyenme
8314319: The approval request has been created successfully.