Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 15, 2025

I backport this test change as it also goes to 17.0.17-oracle.

Omitted TEST.groups and resolved one of the files as it differs slightly.
Pointless as removed anyways.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345838 needs maintainer approval

Issue

  • JDK-8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3576/head:pull/3576
$ git checkout pull/3576

Update a local copy of the PR:
$ git checkout pull/3576
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3576

View PR using the GUI difftool:
$ git pr show -t 3576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3576.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f8974ba718b3a631abafa8987d3fb98164fb35e5 8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test May 15, 2025
@openjdk
Copy link

openjdk bot commented May 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 15, 2025
@mlbridge
Copy link

mlbridge bot commented May 15, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 15, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 20, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 21, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2025

Going to push as commit 3f39815.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2025
@openjdk openjdk bot closed this May 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2025
@openjdk
Copy link

openjdk bot commented May 21, 2025

@GoeLin Pushed as commit 3f39815.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8345838 branch May 21, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants