-
Notifications
You must be signed in to change notification settings - Fork 228
8358334: C2/Shenandoah: incorrect execution with Unsafe #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8358334: C2/Shenandoah: incorrect execution with Unsafe #3770
Conversation
👋 Welcome back roland! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, thanks.
@rwestrel This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
21u patch doesn't apply cleanly but only because some code that's
replaced still uses
NULL
instead ofnullptr
. Otherwise, patch isidentical to 21u patch.
Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3770/head:pull/3770
$ git checkout pull/3770
Update a local copy of the PR:
$ git checkout pull/3770
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3770/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3770
View PR using the GUI difftool:
$ git pr show -t 3770
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3770.diff
Using Webrev
Link to Webrev Comment