Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 21, 2025

I backport this for parity with 17.0.17-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8139392 needs maintainer approval
  • JDK-8140527 needs maintainer approval

Issues

  • JDK-8140527: JInternalFrame has incorrect title button width (Bug - P3)
  • JDK-8139392: JInternalFrame has incorrect padding (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3866/head:pull/3866
$ git checkout pull/3866

Update a local copy of the PR:
$ git checkout pull/3866
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3866

View PR using the GUI difftool:
$ git pr show -t 3866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3866.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport acf591e856ce4b43303b1578bd64a8c9ab0063ea 8140527: JInternalFrame has incorrect title button width Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2025

Webrevs

@GoeLin GoeLin marked this pull request as draft August 21, 2025 09:46
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required
Development

Successfully merging this pull request may close these issues.

1 participant