-
Notifications
You must be signed in to change notification settings - Fork 232
8305186: Reference.waitForReferenceProcessing should be more accessible to tests #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305186: Reference.waitForReferenceProcessing should be more accessible to tests #4072
Conversation
|
I have verified this clean backport PR locally with test test/jdk/java/lang/ref/FinalizerHistogramTest.java which use the newly added function. |
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Clean backport to enhance test library which will fix test bug cause some test intermittently fails. Change has been verified with test test/jdk/java/lang/ref/FinalizerHistogramTest.java after backport JDK-8298783 manually, which use the newly added function by JDK-8305186. Test-fix only, no risk. |
|
@sendaoYan |
|
Thanks for the approved. /integrate |
|
Going to push as commit a64ed9d.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit a64ed9d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit d8f012ea from the openjdk/jdk repository.
The commit being backported was authored by Brent Christian on 25 Apr 2025 and was reviewed by Kim Barrett.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4072/head:pull/4072$ git checkout pull/4072Update a local copy of the PR:
$ git checkout pull/4072$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4072/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4072View PR using the GUI difftool:
$ git pr show -t 4072Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4072.diff
Using Webrev
Link to Webrev Comment