Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 20, 2025

I backport this for parity with 17.0.18-oracle

Based on the push to 21. Trivial resolves, probably clean anyways.

Needed to resolve these as "8283698: Refactor Locale constructors used in src/test" is only in 19.
test/jdk/java/text/Format/DateFormat/bug4358730.java
Resolved time zone string.
test/jdk/java/util/PluggableLocale/TimeZoneNameProviderTest.java
Copyright
test/jdk/sun/util/resources/TimeZone/Bug4640234.java
Copyright

Several changes missing in 17:
test/jdk/sun/security/x509/X509CertImpl/V3Certificate.java
Copyright


Progress

  • JDK-8347841 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347841: Test fixes that use deprecated time zone IDs (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4073/head:pull/4073
$ git checkout pull/4073

Update a local copy of the PR:
$ git checkout pull/4073
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4073

View PR using the GUI difftool:
$ git pr show -t 4073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4073.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347841: Test fixes that use deprecated time zone IDs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title backport from 21 backport 50537aefc736db43e4b08133dcd181ba69f10e8d Oct 20, 2025
@openjdk openjdk bot changed the title backport 50537aefc736db43e4b08133dcd181ba69f10e8d 8347841: Test fixes that use deprecated time zone IDs Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 20, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2025

Webrevs

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 21, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 24, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

Going to push as commit 2a0b143.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2025
@openjdk openjdk bot closed this Oct 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@GoeLin Pushed as commit 2a0b143.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8347841 branch October 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant