Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 23, 2025

Syncs up GHA definitions to make more GHA backports clean.

Testing:

  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8341861 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8341861: GHA: Use only retention mechanism to remove bundles (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4094/head:pull/4094
$ git checkout pull/4094

Update a local copy of the PR:
$ git checkout pull/4094
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4094

View PR using the GUI difftool:
$ git pr show -t 4094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4094.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341861: GHA: Use only retention mechanism to remove bundles

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 29ae26517f9c1fd5e641b3a560aa93e370920506 8341861: GHA: Use only retention mechanism to remove bundles Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Syncs up GHA definitions to make more GHA backports clean. Applies almost cleanly, with minor contextual differences. GHA works fine. Risk is low: GHA only patch.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@shipilev
8341861: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 23, 2025
Copy link
Member

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2025
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

Going to push as commit b04b10a.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2025
@openjdk openjdk bot closed this Oct 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@shipilev Pushed as commit b04b10a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants