Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 13, 2025

I backport this as prereq of JDK-8365790, which calls configureEnvironment() added here.

Backport of the change in 21.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333569 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8333569: jpackage tests must run app launchers with retries on Linux only

Issue

  • JDK-8333569: jpackage tests must run app launchers with retries on Linux only (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4180/head:pull/4180
$ git checkout pull/4180

Update a local copy of the PR:
$ git checkout pull/4180
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4180

View PR using the GUI difftool:
$ git pr show -t 4180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4180.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ce312b3ecbbacaf23f4b2893898ce8de8cd53daa 8333569: jpackage tests must run app launchers with retries on Linux only Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant