8386085: Livelock in AbstractQueuedSyncronizer.cleanQueue() when multiple threads do tryAcquire() with a short timeout and no permits available

[kirill-shirokov]

Please note that it cannot be a clean fix, because the tests were fixed for JDK 17 where ExecutorService does not yet implement AutoCloseable. The additional fix (comparing to the clean one) is made as a separate commit

Testing done:

• 8386085-BugReproducer2-17-linux-x64.log
• juc-tests-17-linux-x64.log
• juc-tests-17-macosx-aarch64.log
• juc-tests-17-windows-x64.log

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8386085 needs maintainer approval

Issue

• JDK-8386085: Livelock in AbstractQueuedSyncronizer.cleanQueue() when multiple threads do tryAcquire() with a short timeout and no permits available (Bug - P3)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4529/head:pull/4529
$ git checkout pull/4529

Update a local copy of the PR:
$ git checkout pull/4529
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4529

View PR using the GUI difftool:
$ git pr show -t 4529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4529.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kshiroko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @kirill-shirokov This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2b9f2c2b)
• 00: Full (42e67c6c)

[phohensee]

Not an expert on this, but doesn't AutoClosable imply you need a finally block on your try?

[kirill-shirokov]

Not an expert on this, but doesn't AutoClosable imply you need a finally block on your try?

With AutoCloseable you don't have to specify finally { resource.close(); } block -- it is done automagically.
Without AC (like in this PR) you have to provide your own finally block, which was done here:

• https://github.com/openjdk/jdk17u-dev/pull/4529/changes#diff-a00f454deaba600ea1678f9e55b09d11dccc0480a0809e61698ba45659437ca0R1563
• https://github.com/openjdk/jdk17u-dev/pull/4529/changes#diff-f52cc247af238586cd86d796d368ae414b09c86b58e36fce6dd047d9fdf25a3dR712

[phohensee]

I see it now. :)