Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 #1100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sophia-guo
Copy link

@sophia-guo sophia-guo commented Oct 28, 2024

Hi, I would like to backport 8333248 to jdk21u. As JDK-8325520 was also backported to 21 so the test now fails on risc-v there.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333248 needs maintainer approval

Issue

  • JDK-8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1100/head:pull/1100
$ git checkout pull/1100

Update a local copy of the PR:
$ git checkout pull/1100
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1100

View PR using the GUI difftool:
$ git pr show -t 1100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1100.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 28, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2024

Hi @sophia-guo, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user sophia-guo" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9b0a5c5cd056262fab99525e9260762b617152a3 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 Oct 28, 2024
@openjdk
Copy link

openjdk bot commented Oct 28, 2024

This backport pull request has now been updated with issue from the original commit.

@sophia-guo
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 28, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2024

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@sophia-guo
Copy link
Author

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2024

@robilad @sophia-guo Is a Red Hat employee and is covered by the RH OCA. Could you please look into her OCA status, thanks!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

⚠️ @sophia-guo This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Nov 14, 2024

@sophia-guo Please enable GHA testing for your fork. See: https://github.com/openjdk/jdk21u-dev/pull/1100/checks?check_run_id=32172108437 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants