Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330846: Add stacks of mounted virtual threads to the HotSpot thread dump #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jia-wei-tang
Copy link

@jia-wei-tang jia-wei-tang commented Nov 6, 2024

I have two reasons to backport 8330846.

  1. When run the jtreg test test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java with the option -testThreadFactory:Virtual, it will fail because of the loss of TestThreadDumpEvent.main in the result.
  2. It helps developers to have a better view of their programs.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330846 needs maintainer approval

Issue

  • JDK-8330846: Add stacks of mounted virtual threads to the HotSpot thread dump (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1129/head:pull/1129
$ git checkout pull/1129

Update a local copy of the PR:
$ git checkout pull/1129
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1129

View PR using the GUI difftool:
$ git pr show -t 1129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1129.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fcedde804277af5a26febdcfb7817858d72f01ab 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump Nov 6, 2024
@openjdk
Copy link

openjdk bot commented Nov 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

⚠️ @jia-wei-tang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@jia-wei-tang
Copy link
Author

/approval request backport 8330846 to jdk21-dev because of two reasons.

  1. When run the jtreg test test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java with the option -testThreadFactory:Virtual, it will fail because of the loss of TestThreadDumpEvent.main in the result.
  2. It helps developers to have a better view of their programs.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@jia-wei-tang
8330846: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 6, 2024
@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2024

Hi @jia-wei-tang,
what about follow-up JDK-8334215, is this needed also?
Removing the label in the meantime.

@openjdk openjdk bot removed the approval label Nov 8, 2024
@jia-wei-tang
Copy link
Author

Hi @jia-wei-tang, what about follow-up JDK-8334215, is this needed also? Removing the label in the meantime.

Yes, It is needed. Should I backport JDK-8334215 in the same pr or create a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants