Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342188: Update tests to use stronger key parameters and certificates #1145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 11, 2024

I backport this for parity with 21.0.6-oracle.

Locally a clean patch, but /backport did not work.
lib files included in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342188 needs maintainer approval

Issue

  • JDK-8342188: Update tests to use stronger key parameters and certificates (Sub-task - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1145/head:pull/1145
$ git checkout pull/1145

Update a local copy of the PR:
$ git checkout pull/1145
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1145

View PR using the GUI difftool:
$ git pr show -t 1145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1145.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe 8342188: Update tests to use stronger key parameters and certificates Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 11, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 12, 2024

GHA failure: infra issue, unrelated
xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant