Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343343: Misc crash dump improvements on more platforms after JDK-8294160 #1154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 13, 2024

Mostly clean backport of JDK-8343343. PPC64 files use a different frame constructor after JDK-8290965 (JDK23). Includes JDK-8343149.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343149 needs maintainer approval
  • JDK-8343343 needs maintainer approval

Issues

  • JDK-8343343: Misc crash dump improvements on more platforms after JDK-8294160 (Bug - P4)
  • JDK-8343149: Cleanup os::print_tos_pc on AIX (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1154/head:pull/1154
$ git checkout pull/1154

Update a local copy of the PR:
$ git checkout pull/1154
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1154

View PR using the GUI difftool:
$ git pr show -t 1154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1154.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e33dc13567a4f0d9a6c1ae63fa0424ca27d52584 8343343: Misc crash dump improvements on more platforms after JDK-8294160 Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 13, 2024
@TheRealMDoerr
Copy link
Contributor Author

/issue add JDK-8343149

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

@TheRealMDoerr
Adding additional issue to issue list: 8343149: Cleanup os::print_tos_pc on AIX.

@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review! GHA failures on macOS-aarch64 are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants