Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an ApplicationMenu class to the javafx.application package #1622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dkkopp
Copy link

@dkkopp dkkopp commented Nov 1, 2024

Added an ApplicationMenu class that provides support for adding About and Settings menu items and handlers to JavaFX applications running on macOS. This provides similar functionality to java.awt.Desktop's setAboutHandler and setPreferencesHandler methods.

A new enumeration value, APPLICATION_MENU, had been added to ConditionalFeature, and a new method called getAboutHandler has been added to javafx.application.Application.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1622/head:pull/1622
$ git checkout pull/1622

Update a local copy of the PR:
$ git checkout pull/1622
$ git pull https://git.openjdk.org/jfx.git pull/1622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1622

View PR using the GUI difftool:
$ git pr show -t 1622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1622.diff

…he application's OS menu on platforms that support it.
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2024

👋 Welcome back dkkopp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant