Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectioning text format output #136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

etki
Copy link

@etki etki commented Oct 17, 2024

Sometimes there is a lot of metrics, and grasping the gist / looking for a difference in a wall of text may be a challenge. This PR adds capability to partition the output by metric, parameter set, benchmark, or several at once. It's probably easier to show:

-Djmh.text.spacing=1 -Djmh.text.aggregation=benchmark


JMHSample_39_ManualValidation.piglet1                        Arasaka       1  avgt        44.078                 ns/op
JMHSample_39_ManualValidation.piglet1                        Arasaka  232552  avgt        44.157                 ns/op
JMHSample_39_ManualValidation.piglet1                           TCTF       1  avgt        44.100                 ns/op
JMHSample_39_ManualValidation.piglet1                           TCTF  232552  avgt        44.178                 ns/op
JMHSample_39_ManualValidation.piglet1:CPI                    Arasaka       1  avgt         1.079             clks/insn
JMHSample_39_ManualValidation.piglet1:IPC                    Arasaka       1  avgt         0.927             insns/clk
...
JMHSample_39_ManualValidation.piglet1:iTLB-loads                TCTF  232552  avgt         0.001                  #/op
JMHSample_39_ManualValidation.piglet1:instructions              TCTF  232552  avgt       175.825                  #/op

JMHSample_39_ManualValidation.piglet2                        Arasaka       1  avgt        43.982                 ns/op
JMHSample_39_ManualValidation.piglet2                        Arasaka  232552  avgt        44.070                 ns/op
JMHSample_39_ManualValidation.piglet2                           TCTF       1  avgt        44.016                 ns/op
JMHSample_39_ManualValidation.piglet2                           TCTF  232552  avgt        43.986                 ns/op
JMHSample_39_ManualValidation.piglet2:CPI                    Arasaka       1  avgt         1.073             clks/insn
JMHSample_39_ManualValidation.piglet2:IPC                    Arasaka       1  avgt         0.932             insns/clk

-Djmh.text.spacing=1 -Djmh.text.aggregation=metric

Benchmark                                                    (alpha)  (beta)  Mode  Cnt    Score   Error      Units

JMHSample_39_ManualValidation.piglet1                        Arasaka       1  avgt        44.058                 ns/op
JMHSample_39_ManualValidation.piglet1                        Arasaka  232552  avgt        44.169                 ns/op
JMHSample_39_ManualValidation.piglet1                           TCTF       1  avgt        44.060                 ns/op
JMHSample_39_ManualValidation.piglet1                           TCTF  232552  avgt        43.950                 ns/op
...
JMHSample_39_ManualValidation.piglet3                           TCTF       1  avgt        44.082                 ns/op
JMHSample_39_ManualValidation.piglet3                           TCTF  232552  avgt        44.377                 ns/op

JMHSample_39_ManualValidation.piglet1:CPI                    Arasaka       1  avgt         1.062             clks/insn
JMHSample_39_ManualValidation.piglet1:CPI                    Arasaka  232552  avgt         1.062             clks/insn
JMHSample_39_ManualValidation.piglet1:CPI                       TCTF       1  avgt         1.062             clks/insn
JMHSample_39_ManualValidation.piglet1:CPI                       TCTF  232552  avgt         1.063             clks/insn
JMHSample_39_ManualValidation.piglet2:CPI                    Arasaka       1  avgt         1.063             clks/insn
JMHSample_39_ManualValidation.piglet2:CPI                    Arasaka  232552  avgt         1.061             clks/insn
JMHSample_39_ManualValidation.piglet2:CPI                       TCTF       1  avgt         1.062             clks/insn
JMHSample_39_ManualValidation.piglet2:CPI                       TCTF  232552  avgt         1.066             clks/insn

-Djmh.text.spacing=1 -Djmh.text.aggregation=parameter

Benchmark                                                    (alpha)  (beta)  Mode  Cnt    Score   Error      Units

JMHSample_39_ManualValidation.piglet1                        Arasaka       1  avgt        44.084                 ns/op
JMHSample_39_ManualValidation.piglet2                        Arasaka       1  avgt        43.963                 ns/op
JMHSample_39_ManualValidation.piglet3                        Arasaka       1  avgt        44.087                 ns/op
JMHSample_39_ManualValidation.piglet1:CPI                    Arasaka       1  avgt         1.064             clks/insn
JMHSample_39_ManualValidation.piglet1:IPC                    Arasaka       1  avgt         0.940             insns/clk
JMHSample_39_ManualValidation.piglet1:L1-dcache-load-misses  Arasaka       1  avgt         1.095                  #/op
...
JMHSample_39_ManualValidation.piglet3:iTLB-loads             Arasaka       1  avgt         0.001                  #/op
JMHSample_39_ManualValidation.piglet3:instructions           Arasaka       1  avgt       176.416                  #/op

JMHSample_39_ManualValidation.piglet1                        Arasaka  232552  avgt        44.129                 ns/op
JMHSample_39_ManualValidation.piglet2                        Arasaka  232552  avgt        44.155                 ns/op

This one is a bit nasty due to the primary results all stacking together, but i hope we can afford this. I do want to do a full-blown rearchitecture, i don't want to get cursed by somebody from another continent for some unexpected format skew.

-Djmh.text.spacing=1 -Djmh.text.aggregation=metric,parameter

JMHSample_39_ManualValidation.piglet1:instructions           Arasaka  232552  avgt       175.356                  #/op
JMHSample_39_ManualValidation.piglet2:instructions           Arasaka  232552  avgt       174.036                  #/op
JMHSample_39_ManualValidation.piglet3:instructions           Arasaka  232552  avgt       175.776                  #/op

JMHSample_39_ManualValidation.piglet1:instructions              TCTF       1  avgt       174.805                  #/op
JMHSample_39_ManualValidation.piglet2:instructions              TCTF       1  avgt       174.786                  #/op
JMHSample_39_ManualValidation.piglet3:instructions              TCTF       1  avgt       173.518                  #/op

JMHSample_39_ManualValidation.piglet1:instructions              TCTF  232552  avgt       174.973                  #/op
JMHSample_39_ManualValidation.piglet2:instructions              TCTF  232552  avgt       174.458                  #/op
JMHSample_39_ManualValidation.piglet3:instructions              TCTF  232552  avgt       175.631                  #/op

I've split it into several commits as changes are relatively big. The obvious questions are what to finalize here and which docs to update.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/136/head:pull/136
$ git checkout pull/136

Update a local copy of the PR:
$ git checkout pull/136
$ git pull https://git.openjdk.org/jmh.git pull/136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 136

View PR using the GUI difftool:
$ git pr show -t 136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/136.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 17, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

Hi @etki, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user etki" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@etki Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@etki Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

@etki This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant