-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sectioning text format output #136
base: master
Are you sure you want to change the base?
Conversation
Hi @etki, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user etki" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
0b24b9b
to
32591ea
Compare
@etki Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
32591ea
to
4aa1913
Compare
@etki Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@etki This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Sometimes there is a lot of metrics, and grasping the gist / looking for a difference in a wall of text may be a challenge. This PR adds capability to partition the output by metric, parameter set, benchmark, or several at once. It's probably easier to show:
-Djmh.text.spacing=1 -Djmh.text.aggregation=benchmark
-Djmh.text.spacing=1 -Djmh.text.aggregation=metric
-Djmh.text.spacing=1 -Djmh.text.aggregation=parameter
This one is a bit nasty due to the primary results all stacking together, but i hope we can afford this. I do want to do a full-blown rearchitecture, i don't want to get cursed by somebody from another continent for some unexpected format skew.
-Djmh.text.spacing=1 -Djmh.text.aggregation=metric,parameter
I've split it into several commits as changes are relatively big. The obvious questions are what to finalize here and which docs to update.
Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/136/head:pull/136
$ git checkout pull/136
Update a local copy of the PR:
$ git checkout pull/136
$ git pull https://git.openjdk.org/jmh.git pull/136/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 136
View PR using the GUI difftool:
$ git pr show -t 136
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/136.diff