Conversation
joemull
left a comment
There was a problem hiding this comment.
Looks good to me. I found one tiny bug. Also consider combining some of the instances of verbose blocks into single templates which are included in multiple places, to make it easier to maintain going forward.
| </ul> | ||
| </div> | ||
| <section aria-label="pagination"> | ||
| <div class="pagination-block">{{ page }} |
There was a problem hiding this comment.
I think the {{ page }} here is a bug. You caught it in the other paste of this code and removed it. Maybe combine these two instances with a sub-template to make them easier to maintain?
c457b14 to
53750df
Compare
f176d03 to
afdb7be
Compare
I've had a look into making pagination templates (beyond those which currently exist) but there is a lot of difference between the logic used in each place and each theme needs different classes, all together, this woudl end up with each new template being used once. However I take the point on standardising - and what can be standardised is the part that the user interacts with, e.g. the previous page and next page buttons could be pulled out as templates. This would also make it easier to update when we get rid of the |
|
page icons: {% include "elements/icons/page_previous.html" %}{% include "elements/icons/page_next.html" %} |
closes #4842
closes #4247