Skip to content

pagination arrows a11y update#4843

Merged
ajrbyers merged 4 commits intomasterfrom
b-4842-arrow-a11y
Aug 7, 2025
Merged

pagination arrows a11y update#4843
ajrbyers merged 4 commits intomasterfrom
b-4842-arrow-a11y

Conversation

@StephDriver
Copy link
Copy Markdown
Member

@StephDriver StephDriver commented Jul 8, 2025

closes #4842
closes #4247

@StephDriver StephDriver changed the base branch from master to a11y-1.9 July 8, 2025 09:54
@StephDriver StephDriver linked an issue Jul 8, 2025 that may be closed by this pull request
@StephDriver StephDriver requested a review from joemull July 8, 2025 09:56
Copy link
Copy Markdown
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I found one tiny bug. Also consider combining some of the instances of verbose blocks into single templates which are included in multiple places, to make it easier to maintain going forward.

</ul>
</div>
<section aria-label="pagination">
<div class="pagination-block">{{ page }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the {{ page }} here is a bug. You caught it in the other paste of this code and removed it. Maybe combine these two instances with a sub-template to make them easier to maintain?

@joemull joemull assigned StephDriver and unassigned joemull Jul 14, 2025
@joemull joemull force-pushed the a11y-1.9 branch 3 times, most recently from c457b14 to 53750df Compare July 16, 2025 13:06
Base automatically changed from a11y-1.9 to master July 16, 2025 13:28
@StephDriver
Copy link
Copy Markdown
Member Author

StephDriver commented Jul 25, 2025

...Also consider combining some of the instances of verbose blocks into single templates which are included in multiple places, to make it easier to maintain going forward.

I've had a look into making pagination templates (beyond those which currently exist) but there is a lot of difference between the logic used in each place and each theme needs different classes, all together, this woudl end up with each new template being used once.

However I take the point on standardising - and what can be standardised is the part that the user interacts with, e.g. the previous page and next page buttons could be pulled out as templates. This would also make it easier to update when we get rid of the &laquo; etc to replace with an icon set. And it would ensure all page change links are marked up accessibly.

@StephDriver
Copy link
Copy Markdown
Member Author

page icons:

{% include "elements/icons/page_previous.html" %}
{% include "elements/icons/page_next.html" %}

@StephDriver StephDriver requested a review from joemull July 25, 2025 09:58
@StephDriver StephDriver assigned joemull and unassigned StephDriver Jul 25, 2025
@ajrbyers ajrbyers self-requested a review August 7, 2025 07:50
@ajrbyers ajrbyers self-assigned this Aug 7, 2025
Copy link
Copy Markdown
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here.

@ajrbyers ajrbyers merged commit 2792ada into master Aug 7, 2025
1 check passed
@ajrbyers ajrbyers deleted the b-4842-arrow-a11y branch August 7, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make left and right arrows accessible Add context for page numbers for screenreaders

3 participants