issue# 307 fix: Failure detection by maximum retry fail doesnt take the exact value set in exchange.max-retry-count config parameter #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahanapradhan
changed the title
ahanapradhan
changed the title
|
lgtm |
…alue set in exchange.max-retry-count config parameter
|
/sync |
1 similar comment
|
/sync |
|
@sraghunandan: This pr has been synchronized to the Gitee Repository In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository. |
|
lgtm |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 473599daf87aad3e140f4236fe8d1cad7af5ce98
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahanapradhan, sraghunandan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why do we need it:
for max-retry based failure detection mechanism, exchange.max-retry-count value is used to retry failed task.
Once that number of times retry fails, query is failed.
The issue is: the number of retry happens doesn't match the configured value exchange.max-retry-count.
If exchange.max-retry-count=20 is set, retry happens for 21, 23, 24.. for random number of times which is some value close to 20, but it never is 20.
When exchange.max-retry-count is not set, default value 10 is considered. But retry happens for 15 (or so) times.
Cause:
failure count is modified using two synchronized methods --> Backoff.failure() and Backoff.maxTried().
Two threads can parallely use these two methods.
Unless read/write of failure count is not made synchronized, the number cannot match the exact expected number in presence of multiple threads.
This fix use synchronized getter and setter methods to read/update failure count value.
Which issue(s) this PR fixes:
Fixes #307
https://gitee.com/openlookeng/hetu-core/issues/I4WGE1
Special notes for your reviewers: