Open
Conversation
…g BECAUSE it tries to talk to a vllm container TODO: parameterize the URL
…ither needed at build OR plumbing
… I have tested their functionality
…enai api client is different from an available tokenizer
3bf9bb8 to
d23b333
Compare
d0a4894 to
8037c23
Compare
…fault prompt" This reverts commit e9d45ce.
321d8b0 to
a9eb818
Compare
…function that does translation to mpf.VideoTrack
… as they don't make sense for speech
…sible error is detected during completion
…enizers during docker build
jrobble
reviewed
Mar 20, 2026
Member
jrobble
left a comment
There was a problem hiding this comment.
@jrobble resolved 16 discussions.
Reviewable status: 12 of 22 files reviewed, all discussions resolved (waiting on tstrass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Related PRs:
This change is