Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)O3-4372:Feature flags that no longer exist should be removed from local storage #1276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(fix)O3-4372:Feature flags that no longer exist should be removed from local storage #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/framework/esm-feature-flags/src/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ featureFlagsStore.subscribe((state) => {
JSON.stringify({ label: flag.label, description: flag.description }),
);
}
cleanupObsoleteFeatureFlags(state.flags);
});

function getFeatureFlagsFromLocalStorage() {
Expand Down Expand Up @@ -62,6 +63,22 @@ export function registerFeatureFlag(flagName: string, label: string, description
},
},
}));
cleanupObsoleteFeatureFlags();
}

/**
* This function removes feature flags from local storage that no longer exist in the current state.
*/
function cleanupObsoleteFeatureFlags(currentFlags?: FeatureFlagsStore['flags']) {
const flags = currentFlags || featureFlagsStore.getState().flags;
const storedFlags = Object.keys(localStorage).filter((key) => key.startsWith('openmrs:feature-flag:'));
storedFlags.forEach((key) => {
const flagName = key.replace('openmrs:feature-flag:', '');
if (!flags[flagName]) {
localStorage.removeItem(key);
localStorage.removeItem(`openmrs:feature-flag-meta:${flagName}`);
}
});
}

/** Use this function to access the current value of the feature flag
Expand Down
Loading