Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: O3-4478: Redirect logged-in users from login page to home #1296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lemeri123
Copy link

@Lemeri123 Lemeri123 commented Feb 27, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

fixes O3-4478 and prevents logged in users from being redirected back to the login page since they are already logged in

Screenshots

Screencast.from.2025-02-27.19-00-38.webm

Related Issue

Other

Copy link
Contributor

@Muppasanipraneeth Muppasanipraneeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lemeri123 Thanks for picking this 😊 but I tested It locally but its not working as expected

  • Login to the application it means already login and
  • Now go back to /openmrs/spa/login
  • Since you are already logged in, it should’ve redirected you to /openmrs/spa, but it doesn’t

screen recording

Screen.Recording.2025-02-27.at.5.41.43.PM.mov

@Muppasanipraneeth
Copy link
Contributor

@Lemeri123 Thanks for picking this 😊 but I tested It locally but its not working as expected

  • Login to the application it means already login and
  • Now go back to /openmrs/spa/login
  • Since you are already logged in, it should’ve redirected you to /openmrs/spa, but it doesn’t

screen recording

Screen.Recording.2025-02-27.at.5.41.43.PM.mov

if user is authenticated should be redirected

@Lemeri123
Copy link
Author

Screencast from 2025-02-27 19-00-38.webm
Here is a screen recording. I just tested it and it works fine

@Muppasanipraneeth
Copy link
Contributor

I will check it once again

Screencast from 2025-02-27 19-00-38.webm Here is a screen recording. I just tested it and it works fine

I will check it once again

@Muppasanipraneeth
Copy link
Contributor

Muppasanipraneeth commented Feb 28, 2025

  • ya its working

screen recording

Screen.Recording.2025-02-28.at.8.21.43.AM.mov

@Muppasanipraneeth
Copy link
Contributor

@denniskigen @vasharma05 Can you check this? It looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants