Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FM2-130:Adding support for the FHIR Media resource #328
base: master
Are you sure you want to change the base?
FM2-130:Adding support for the FHIR Media resource #328
Changes from 10 commits
d785e97
68e5bd4
d508846
39be2b1
0aca54d
b28be07
53d8ff7
ba5c351
027f483
9fda48d
5041fa2
f4a4bed
1ba904b
dd4b80e
da7d841
aea79f8
b26adb3
d2625e6
74103bc
119fb76
619d08b
ee13f88
86e2ca9
a8c2605
3933575
93f2f45
9c843e8
bb9dbdf
b6888be
6d2e407
5c79a15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unnecessary as it's already defined by the parent interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class definitely shouldn't be a
ComplexObsHandler
. That interface is only for classes which implement a specific type ofComplexObs
, e.g.,ImageHandler
orPdfHandler
or something like that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we'll want to ensure that we're only searching ComplexObs and not just any Obs. This looks like it could be done as something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really, really don't need a FHIR-specific
ComplexObsHandler
we can rely on theObsService
to populate theComplexObs
data (if any)