Skip to content

Conversation

@0x617374726F
Copy link
Contributor

No description provided.

@AmyrAhmady
Copy link
Member

rebase your branch please

@0x617374726F
Copy link
Contributor Author

Sure. I'm still having an issue though that might be related to this. Using my omprs component, dialogs won't show up if invoked from within on_player_connect callback. It works though if invoked by a command. Note that it didn't work before that PR either.

@AmyrAhmady
Copy link
Member

Ask omprs dev to test it, I'll test in my own test environment too

@0x617374726F
Copy link
Contributor Author

On omprs side, I am able to workaround the issue by deferring the show dialog invocation to the next tick. That's what we actually do for quite some API calls that are likely to cause new events coming in. In general, this enables us to comply with the borrow checking rules.
But I think that this problem is about something different and not multiple mutable references being held, since the component won't panic in this case.
Therefore, I suspect that the bug can be reproduced by using capi directly.

@AmyrAhmady AmyrAhmady merged commit 611f787 into openmultiplayer:master Nov 20, 2025
13 checks passed
@AmyrAhmady
Copy link
Member

The issue is omprs adds event handlers with highest priority instead of default value. It's not happening when it's set to FairlyLow or Lowest. Yet this can be prevented in another way, which I'm making a PR for. @0x617374726F

@AmyrAhmady
Copy link
Member

Fixed by #1145

@0x617374726F 0x617374726F deleted the fix-event-handling branch November 20, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants